With the fix when the user releases all the keys the call is muted again and the behavior doesn't depend on the order of releasing the keys. When the user first releases one of the control keys the call stays unmuted when all keys are released. On Mar 25, 2013, at 11:01 AM, Hristo Terezov wrote: Thanks for fixing the problem! It works great! Of the pressed events when the key is hold down.Now jitsi receives only 1 > I added a flag when the shortcuts are registered to prevent repeating Shortcut for the push to talk the call is unmuted, when you release the > The feature can be tested if you are in call when you press the On Fri, at 9:42 PM, Hristo Terezov wrote: With the fix when the user releases all the keys the call is muted againĪnd the behavior doesn't depend on the order of releasing the keys. When the user first releases one of the control keys the call stays unmuted I'm attaching next version of the patch where the issue on mac os is fixed. > The shortcuts are changed to work on press instead of on release of the > I added a flag when the shortcuts are registered to prevent repeating of This case jitsi won't receive the events for key press. > There was a situation when some of the shortcuts could be missed. > While I was implementing this feature I made the following improvements > To run the project with this patch the native files for globalshortcut > Note: on windows 64 the global shortcuts are not working at all for me. > The feature can be tested if you are in call when you press the shortcut > I'm attaching the patch for the push to talk global shortcut. On Mar 8, 2013, at 3:16 PM, Hristo Terezov > wrote: That it's very easy to not un-press the keys in the "right" order, so thisĬould happen very often and one could think they're muted again, but they Only one of the control keys of the shortcut I stay un-muted. Key combination I'm un-muted, which is perfect, but then if I just release It works great, I've just encountered one small problem. On Fri, at 9:20 PM, Yana Stamcheva wrote: Sorry I forgot to mention it.Ībout the issue I didn't noticed it while I was testing the feature. I think it's working on linux ( I made some changes in the native code On Mar 8, 2013, at 3:16 PM, Hristo Terezov wrote: What about linux, does this feature work on linux? The shortcuts are changed to work on press instead of on release of the keys. I added a flag when the shortcuts are registered to prevent repeating of the pressed events when the key is hold down.Now jitsi receives only 1 event for press when a shortcut is hold down. In this case jitsi won't receive the events for key press. There was a situation when some of the shortcuts could be missed. While I was implementing this feature I made the following improvements to global shortcuts functionality: To run the project with this patch the native files for globalshortcut should be compiled too. Note: on windows 64 the global shortcuts are not working at all for me. You can set the key combinations from Tools->Options->Advanced->Keybindings. The feature can be tested if you are in call when you press the shortcut for the push to talk the call is unmuted, when you release the shortcut the call is muted again. The thing is that it's very easy to not un-press the keys in the "right" order, so this could happen very often and one could think they're muted again, but they won't be. When I press my key combination I'm un-muted, which is perfect, but then if I just release only one of the control keys of the shortcut I stay un-muted. The shortcuts are changed to work on press instead of on release of the The pressed events when the key is hold down.Now jitsi receives only 1Įvent for press when a shortcut is hold down. I added a flag when the shortcuts are registered to prevent repeating of In thisĬase jitsi won't receive the events for key press. While I was implementing this feature I made the following improvements to To run the project with this patch the native files for globalshortcut The feature can be tested if you are in call when you press the shortcutįor the push to talk the call is unmuted, when you release the shortcut theĬall is muted again. I'm attaching the patch for the push to talk global shortcut.
0 Comments
Leave a Reply. |